server : use httplib status codes #11624
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the status code number with the httplib StatusCode enum values. The motivation for this change is to make the code a little more readable.
Collaborator
|
IMO this change is not really needed because it makes the code become verbose. IIRC this part of code is adapted from openai python library so it's better to keep the status code as-is, no need to replace with an enum |
Collaborator
|
Correction: I'm talking about the code inside format_error_response, I prefer to keep it as-is (also to decouple it from httplib). The rest is ok to move to httplib enum |
Revert changes of using httplib's StatusCode in format_error_response.
ngxson
reviewed
Feb 3, 2025
Remove duplicate status code setting in server.cpp
Fix mistake when setting status code to 503.
Member
Author
|
Closing this as PR to avoid wasting reviewers time. I'd been looking into llama-server part of the code base which was new to me, and "fixing/suggesting" things as part of my learning process. But I had not really considered the time reviewers spend on issue like this. I'll be more selective/careful in the future about opening PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the status code number with the httplib
StatusCodeenum values.The motivation for this change is to make the code a little more readable.